Editor, Bureaucrats, Administrators
1,155
edits
(Created page with "== Smoothing the illumos integration process. == Compared to other platforms, it is relatively more difficult to set up a build environment and test ZFS changes on illumos. ...") |
|||
Line 8: | Line 8: | ||
* Finish porting all the ZFS test cases from the STF framework to the TestRunner framework, which lives in the illumos gate. | * Finish porting all the ZFS test cases from the STF framework to the TestRunner framework, which lives in the illumos gate. | ||
* Create a script that will run on OmniOS and set up a build environment, get the ZFS code, apply a patch, build it, install it, run the TestRunner test suite, and generate a webrev which can be used to review the code on the zfs@lists.illumos.org mailing list. | * Create a script that will run on OmniOS and set up a build environment, get the ZFS code, apply a patch, build it, install it, run the TestRunner test suite, and generate a webrev which can be used to review the code on the zfs@lists.illumos.org mailing list. | ||
== The current illumos development process == | |||
Develop changes: | |||
* For large or controversial changes, consider getting design review on [[mailing list | developer@open-zfs.org]] | |||
* Set up OpenIndiana-based [http://wiki.illumos.org/display/illumos/How+To+Build+illumos development environment] | |||
* Clone repo from [https://github.com/illumos/illumos-gate/tree/master/usr/src/uts/common/fs/zfs github] | |||
* Make code changes | |||
* Run a full build with [http://wiki.illumos.org/display/illumos/How+To+Build+illumos nightly] (runs lint) | |||
* Test with ztest and [https://github.com/illumos/illumos-gate/blob/master/usr/src/test/README TestRunner] | |||
** consider if you need to add a new test case | |||
* Check code style with cstyle tool | |||
Submit code: | |||
* Get your code reviewed on zfs@lists.illumos.org | |||
** cc: [[mailing list | developer@open-zfs.org]] for platform-neutral changes | |||
** non-trivial changes typically must be reviewed by a ZFS expert (e.g. Matt Ahrens or George Wilson) | |||
** preferred tool for creating reviews is [http://wiki.illumos.org/display/illumos/How+To+Contribute#HowToContribute-4CodeReview webrev] | |||
* Submit a “[http://wiki.illumos.org/display/illumos/How+To+Contribute#HowToContribute-5SubmittingAPatch Request to Integrate]” (RTI) email to advocates@lists.illumos.org | |||
* Advocate will integrate (push) your code to github | |||
** Chris Siden is the most active ZFS advocate | |||
* Author, code reviewer, advocate should be different people |